Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file permissions error in style-files pre-commit hook #37

Conversation

jeancochrane
Copy link
Contributor

This PR implements the same change as ccao-data/model-res-avm#244 in order to fix the same bug in the pre-commit workflow. See that PR for more background on this change.

In addition, we switch over to the https://github.com/ccao-data/actions repo for the pre-commit workflow, to bring this repo in line with our other repos that use pre-commit like model-res-avm.

I didn't test timing for serial execution vs parallel execution in the same way that I did in ccao-data/model-res-avm#244 and ccao-data/model-condo-avm#49 since the results of those two PRs have me convinced that serial execution is likely better and at least no worse.

@jeancochrane jeancochrane marked this pull request as ready for review May 28, 2024 18:57
@jeancochrane jeancochrane requested a review from dfsnow as a code owner May 28, 2024 18:57
@jeancochrane
Copy link
Contributor Author

Here again I need @dfsnow's review as a codeowner ☹️

@dfsnow dfsnow merged commit f505712 into master Jun 3, 2024
10 checks passed
@dfsnow dfsnow deleted the jeancochrane/fix-file-permissions-error-for-style-files-pre-commit-hook branch June 3, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants